Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timing Diagram link fixed + Circuit Elements format fixed #297

Merged
merged 1 commit into from
Sep 19, 2021
Merged

Timing Diagram link fixed + Circuit Elements format fixed #297

merged 1 commit into from
Sep 19, 2021

Conversation

MadhuNimmo
Copy link

Fixes # Side Bar Item "Circuit Elements" and "Timing Diagram" Format Mismatch #296

Changes done:

  • [1] Timing Daigram section and subsection fixed
  • [2] Circuit Elements section format fixed

Screenshots:

Screenshot 2021-06-17 at 11 05 56 PM

Preview Link(s):

https://github.com/MadhuNimmo/CircuitVerseDocs/blob/master/docs/_sidebar.md
https://github.com/MadhuNimmo/CircuitVerseDocs/blob/master/docs/timing_diagrams.md

✅️ By submitting this PR, I have verified the following

  • Checked to see if a similar PR has already been opened 🤔️
  • Reviewed the contributing guidelines 🔍️
  • Sample preview link added (add a link from the checks tab after checks complete)
  • Tried Squashing the commits into one

@ShreyaPrasad1209 ShreyaPrasad1209 merged commit 018b646 into CircuitVerse:master Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShreyaPrasad1209 ShreyaPrasad1209 ShreyaPrasad1209 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MadhuNimmo @ShreyaPrasad1209